-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the dynamic fee tx and support for typed txs #903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/galactica #903 +/- ##
====================================================
Coverage ? 61.07%
====================================================
Files ? 224
Lines ? 23817
Branches ? 0
====================================================
Hits ? 14547
Misses ? 8100
Partials ? 1170 ☔ View full report in Codecov by Sentry. |
otherview
reviewed
Dec 2, 2024
e54ad17
to
53b49f1
Compare
otherview
reviewed
Dec 5, 2024
otherview
reviewed
Jan 22, 2025
Loading status checks…
ceb558c
to
3eec5f4
Compare
otherview
approved these changes
Jan 23, 2025
Loading status checks…
otherview
approved these changes
Jan 24, 2025
libotony
pushed a commit
that referenced
this pull request
Feb 13, 2025
* feat: add the dynamic fee tx and support for typed txs * refactor: returning maxFeePerGas or mas uint8 as gasPriceCoef for dynFeeTx * test: add mempool tests with dynFeeTxs type * test: add tests for txpool and logdb * test: add transactions test * refactor: split builder into legacy and dynFee builder * test: add more tests including dynamic fee txs * style: fix linting * fix: switch to LegacyBuilder * test: add more tests * test: add tests for legacy and dynamic tx builder * test: add dynFee tx in initBlockServer test * test: add dynFee tx in tests initializations function * feat: replace rlp.EncodeToBytes with the new tx MarshalBinary * refactor: change tx type codes * test: add more dynFee txs to tests * Rebase to master * feat: differentiate legacy and dyn fee json response * refactor: merge tx builder into one builder * refactor: add MustBuild to tx builder and fix error * refactor: move hashWithoutNonce to concrete tx implementation * fix: use MarshalBinary to encode/decode a tx instead of encodeRLP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refers to a part of the dynamic fee market feature and it introduces a new typed transaction:
DynamicFeeTransaction
. This also allows the introduction of new transaction types. The typed tx model follows the EIP-2718.Type of change
How Has This Been Tested?
Checklist: